[lkml]   [2013]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 001/115] gpu: ion: Add ION Memory Manager
On Fri, Dec 13, 2013 at 02:23:35PM -0800, John Stultz wrote:
> + idev->debug_root = debugfs_create_dir("ion", NULL);
> + if (IS_ERR_OR_NULL(idev->debug_root))
> + pr_err("ion: failed to create debug files.\n");

There's no need to check for this at all, you just printed out an error
message if CONFIG_DEBUGFS is not enabled, which isn't all that nice.

Something to clean up later, no big deal now.


greg k-h

 \ /
  Last update: 2013-12-14 21:01    [W:0.511 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site