[lkml]   [2013]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v4 1/2] ARM: mach-moxart: add MOXA ART SoC platform files
On Friday 13 December 2013, Guenter Roeck wrote:
> On Fri, Dec 13, 2013 at 06:23:44PM +0100, Jonas Jensen wrote:
> > On 13 December 2013 17:17, Arnd Bergmann <> wrote:
> > > I've been out of the loop a bit here. I initially suggested having the restart
> > > handler be part of the watchdog driver, and I thought you had done that in an
> > > earlier version. What has changed your mind?
> >
> > I got the impression from Guenter Roeck's review, that it doesn't belong there,
> > maybe I was too quick to remove it?
> >
> You'd have to answer the questions I raised in my review if you want it in
> there.

Let me reply to your comment from that email:

> > +
> > + arm_pm_restart = moxart_wdt_restart;
> It is quite unusual that system restart code is implemented in a watchdog
> driver (which may not even be compiled into an image, or not be loaded).

I had asked Jonas to do it in the watchdog driver because that driver is
the place that handles this particular register. We have moved a bunch
of restart handlers into drivers/power for similar reasons, and those
can also be compiled out. The restart handler isn't actually essential
for most operations, and we have moved some far more important drivers
from arch/arm into drivers/, such as clocks, interrupts, timers etc.

The restart handler in this case is the only piece of code that remains in
mach-moxart, and I would really like it to be completely empty.


 \ /
  Last update: 2013-12-14 05:21    [W:0.077 / U:2.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site