lkml.org 
[lkml]   [2013]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH v3 07/23] mm/memblock: switch to use NUMA_NO_NODE instead of MAX_NUMNODES
On Mon, Dec 09, 2013 at 04:50:40PM -0500, Santosh Shilimkar wrote:
> + if (nid == MAX_NUMNODES)
> + pr_warn_once("%s: Usage of MAX_NUMNODES is depricated. Use NUMA_NO_NODE instead\n",
> + __func__);

Why not just use WARN_ONCE()? We'd want to know who the caller is
anyway. Also, wouldn't something like the following simpler?

if (WARN_ONCE(nid == MAX_NUMNODES, blah blah))
nid = NUMA_NO_NODE;

> @@ -768,6 +773,11 @@ void __init_memblock __next_free_mem_range_rev(u64 *idx, int nid,
> struct memblock_type *rsv = &memblock.reserved;
> int mi = *idx & 0xffffffff;
> int ri = *idx >> 32;
> + bool check_node = (nid != NUMA_NO_NODE) && (nid != MAX_NUMNODES);
> +
> + if (nid == MAX_NUMNODES)
> + pr_warn_once("%s: Usage of MAX_NUMNODES is depricated. Use NUMA_NO_NODE instead\n",
> + __func__);

Ditto.

Provided the patch is tested on an actual NUMA setup.

Reviwed-by: Tejun Heo <tj@kernel.org>

Thanks.

--
tejun

\
 
 \ /
  Last update: 2013-12-13 23:21    [W:1.153 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site