Messages in this thread |  | | Date | Thu, 12 Dec 2013 10:04:15 +0100 | From | Maxime Ripard <> | Subject | Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's |
| |
Hi,
On Wed, Dec 11, 2013 at 02:45:08PM +0000, srinivas kandagatla wrote: > >>> 1. .tx_coe > >>> This is not exported in the DT bindings. > >>> Looking at stmmac code, not setting this seems to disable all > >>> checksum offloading. > >> > >> Why cant this go via DT as well? > > > > If you and Giuseppe are OK with this, why not? > Am Ok with it.
Please note that I'm opposed to this until someone explain why putting it in the DT is relevant (and not just convenient).
Maxime
-- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com [unhandled content-type:application/pgp-signature] |  |