Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH] Driver core: Fix device_add_attrs() error code path | Date | Fri, 13 Dec 2013 06:00:29 +0100 |
| |
On Thursday, December 12, 2013 03:13:33 PM Greg Kroah-Hartman wrote: > On Thu, Dec 12, 2013 at 06:11:02AM +0100, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > > > If the addition of dev_attr_online fails, device_add_attrs() should > > remove device attribute groups as well as type and class attribute > > groups before returning an error code. Make that happen. > > > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > Does this need tob e in 3.13-final? Or can it wait for 3.14-rc1? The > odds that this file creation would ever fail is _really_ low, right?
Yeah, it's more of a cleanup than a fix, so 3.14-rc1 should be fine.
Thanks, Rafael
| |