lkml.org 
[lkml]   [2013]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subject[PATCH 0/2] ipmi: fix timeout calculation when bmc is disconnected
Hu Shiyuan report, when loading ipmi_si module while bmc is
disconnected, we found the timeout is longer than 5 secs.
Actually it takes about 3 mins and 20 secs (HZ=250).

error message as below:
Dec 12 19:08:59 linux kernel: IPMI BT: timeout in RD_WAIT [ ] 1 retries left
Dec 12 19:08:59 linux kernel: BT: write 4 bytes seq=0x01 03 18 00 01
[...]
Dec 12 19:12:19 linux kernel: IPMI BT: timeout in RD_WAIT [ ]
Dec 12 19:12:19 linux kernel: failed 2 retries, sending error response
Dec 12 19:12:19 linux kernel: IPMI: BT reset (takes 5 secs)
Dec 12 19:12:19 linux kernel: IPMI BT: flag reset [ ]

Function wait_for_msg_done() use schedule_timeout_uninterruptible(1)
to sleep 1 tick, so we should subtract jiffies_to_usecs(1) usecs
instead of 100 usecs from timeout.

For more clearly, I used USEC_PER_SEC instead of 1000000.

Xie XiuQi (2):
ipmi: use USEC_PER_SEC instead of 1000000 for more meaningful
ipmi: fix timeout calculation when bmc is disconnected

drivers/char/ipmi/ipmi_bt_sm.c | 8 ++++----
drivers/char/ipmi/ipmi_kcs_sm.c | 4 ++--
drivers/char/ipmi/ipmi_si_intf.c | 2 +-
drivers/char/ipmi/ipmi_smic_sm.c | 2 +-
4 files changed, 8 insertions(+), 8 deletions(-)

--
1.8.2.2




\
 
 \ /
  Last update: 2013-12-13 04:01    [W:0.042 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site