Messages in this thread | | | Date | Thu, 12 Dec 2013 18:04:13 -0800 | From | Greg Kroah-Hartman <> | Subject | Re: [RFC] dma-buf: Implement test module |
| |
On Thu, Dec 12, 2013 at 03:36:29PM +0100, Thierry Reding wrote: > This is a simple test module that can be used to allocate, export and > delete DMA-BUF objects. It can be used to test DMA-BUF sharing in > systems that lack a real second driver. > > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > drivers/base/Kconfig | 4 + > drivers/base/Makefile | 1 + > drivers/base/dma-buf-test.c | 308 ++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 313 insertions(+) > create mode 100644 drivers/base/dma-buf-test.c > > diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig > index e373671652b0..bed2abb9491b 100644 > --- a/drivers/base/Kconfig > +++ b/drivers/base/Kconfig > @@ -200,6 +200,10 @@ config DMA_SHARED_BUFFER > APIs extension; the file's descriptor can then be passed on to other > driver. > > +config DMA_BUF_TEST > + tristate "DMA-BUF test module" > + depends on DMA_SHARED_BUFFER
We need some good documentation here.
> > +static struct miscdevice dmabuf_device = { > + .minor = 128,
Why did you pick this minor? Why not just make it dynamic?
thanks,
greg k-h
| |