Messages in this thread | | | From | Andy Lutomirski <> | Date | Thu, 12 Dec 2013 16:45:00 -0800 | Subject | Re: [PATCH 1/9] Known exploit detection |
| |
On Thu, Dec 12, 2013 at 4:25 PM, Dave Jones <davej@redhat.com> wrote: > On Thu, Dec 12, 2013 at 01:13:41PM -0800, Kees Cook wrote: > > > - who will keep adding these triggers going forward? > > also.. > > - Who will test the existing triggers are doing the right thing when related code changes. > > We could add something to tests/ maybe for each exploit() addition, to make sure some > new change isn't introducing an oopsable (or worse!) bug in the actual exploit test. > > It does mean someone needs to be regularly running said tests though. > As history has shown, things like nx_test have been broken for months at a time without > anyone complaining. Perhaps Fenguang Wu can add something to the daily test runs if > we add an over all "make test-secure" target or similar.
This has the added benefit of making sure that the exploits don't (trivially) regress.
--Andy
> > Dave >
-- Andy Lutomirski AMA Capital Management, LLC
| |