Messages in this thread |  | | Date | Thu, 12 Dec 2013 21:37:36 +0100 | Subject | Re: [PATCH v3 4/6] pinctrl: Add pinctrl binding for Broadcom Capri SoCs | From | Linus Walleij <> |
| |
On Wed, Dec 11, 2013 at 7:37 PM, Sherman Yin <syin@broadcom.com> wrote:
> Adds pinctrl driver devicetree binding for Broadcom Capri (BCM281xx) SoCs. > > Signed-off-by: Sherman Yin <syin@broadcom.com> > Reviewed-by: Christian Daudt <bcm@fixthebug.org> > Reviewed-by: Matt Porter <matt.porter@linaro.org> > --- > v3: Use generic pin config properties instead of brcm-specific ones. Clarified > pin types (standard, i2c, hdmi). > v2: Use hyphens instead of underscore in DT property names.
Overall this is very nice!
> +- bias-pull-up: Integer. Pull up strength in Ohm: > + 1: 1.2 kOhm > + 2: 1.8 kOhm > + 3: 720 Ohm > + 4: 2.7 kOhm > + 5: 831 Ohm > + 6: 1.08 kOhm > + 7: 568 Ohm
Please do not use these custom enumerators 1 thru 7. Instead say that the argument is given in ohms, so for example:
bias-pull-up = <12000>;
Then translate this into the proper enumerator in your driver instead.
No full example provided in the binding! This needs to be there for understanding.
Yours, Linus Walleij
|  |