Messages in this thread |  | | Date | Thu, 12 Dec 2013 20:22:53 +0000 | From | "Robin H. Johnson" <> | Subject | Re: [PATCH] libata: provide the ability to disable a disk via the params. |
| |
On Thu, Dec 12, 2013 at 08:39:35AM -0500, Tejun Heo wrote: > Hello, Robin. > > On Sat, Dec 07, 2013 at 04:56:27PM -0800, Robin H. Johnson wrote: > > + { "disable", .horkage_on = ATA_HORKAGE_DISABLE }, > > + { "nodisable", .horkage_off = ATA_HORKAGE_DISABLE }, > Given the current usage of ATA_HORKAGE_DISABLE, I don't think we need > "nodisable". Let's just add "disable" for now. Can you please update > the patch and resend? Before I do so, I have two questions: 1. Countering your nodisable comment, would it be valid to do: libata.force=2:disable libata.force=2.02:nodisable To disable all of port 2 except device 2?
2. One of my friends wondered if it would be worthwhile to add force keywords for other HORKAGE bits, and if so, should the ata_lflag/ata_link force bits also be presented?
There are only 3 HORKAGE bits presently available in libata.force: ATA_HORKAGE_NONCQ ATA_HORKAGE_DUMP_ID ATA_HORKAGE_ATAPI_DMADIR
And 3 ata_link flags: ATA_LFLAG_NO_HRST ATA_LFLAG_NO_SRST ATA_LFLAG_RST_ONCE
-- Robin Hugh Johnson Gentoo Linux: Developer, Infrastructure Lead E-Mail : robbat2@gentoo.org GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85
|  |