Messages in this thread |  | | Date | Thu, 12 Dec 2013 19:58:46 -0800 | From | Bjorn Andersson <> | Subject | Re: [PATCH 1/2] gpio: msm: Fix irq mask/unmask by writing bits instead of numbers |
| |
On Thu 12 Dec 11:02 PST 2013, Linus Walleij wrote:
> On Wed, Dec 11, 2013 at 12:19 AM, Stephen Boyd <sboyd@codeaurora.org> wrote: > > > We should be writing bits here but instead we're writing the > > numbers that correspond to the bits we want to write. Fix it by > > wrapping the numbers in the BIT() macro. This fixes gpios acting > > as interrupts. > > > > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> > > I've applied this for fixes and tagged for stable. > Björn, Rohit: OK?
This looks good.
JFYI; the pinctrl-msm is written with gpio-msm-v2 in mind as well, so replacing it with pinctrl is on my todo list...
Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |