Messages in this thread |  | | From | Namhyung Kim <> | Subject | [PATCHSET 00/14] tools lib traceevent: Get rid of *die() calls from parse-filter.c (v2) | Date | Thu, 12 Dec 2013 16:36:03 +0900 |
| |
Hello,
This patchset tries to remove all die() calls in event filter parsing code. I changed two main functions of pevent_filter_add_filter_str() and pevent_filter_match() to return a proper error code (pevent_errno).
The actual error message might be saved in a static buffer in pevent_ filter and it can be accessed by new pevent_filter_strerror() function. The old pevent_strerror() still works for them too.
The only remaining bits are in trace-seq.c which implement print functions and I want to hear what's the best way we can handle the error case during the print.
I also put this patches on libtraceevent/die-removal-v2 branch in my tree
git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
Any comments are welcome, thanks Namhyung
Namhyung Kim (14): tools lib traceevent: Get rid of malloc_or_die() in show_error() tools lib traceevent: Get rid of die in add_filter_type() tools lib traceevent: Get rid of malloc_or_die() allocate_arg() tools lib traceevent: Get rid of malloc_or_die() in read_token() tools lib traceevent: Get rid of malloc_or_die() in find_event() tools lib traceevent: Get rid of die() in add_right() tools lib traceevent: Make add_left() return pevent_errno tools lib traceevent: Get rid of die() in reparent_op_arg() tools lib traceevent: Refactor create_arg_item() tools lib traceevent: Refactor process_filter() tools lib traceevent: Make pevent_filter_add_filter_str() return pevent_errno tools lib traceevent: Refactor pevent_filter_match() to get rid of die() tools lib traceevent: Get rid of die() in some string conversion funcitons tools lib traceevent: Introduce pevent_filter_strerror()
tools/lib/traceevent/event-parse.c | 17 +- tools/lib/traceevent/event-parse.h | 48 ++- tools/lib/traceevent/parse-filter.c | 615 ++++++++++++++++++++++-------------- 3 files changed, 417 insertions(+), 263 deletions(-)
-- 1.7.11.7
|  |