lkml.org 
[lkml]   [2013]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cgroup: fix fail path in cgroup_load_subsys()
Hello,

On Thu, Dec 12, 2013 at 10:37:32PM +0400, Vladimir Davydov wrote:
> If so, I don't mind, but why? cgroup_unload_subsys() should never be
> called without properly initialized css.

Hmm.... I think it's generally preferable to reuse normal exit path
for error handling as much as possible. Plus, the normal cgroup init
failure path behaves that way. That said, it's more of a preference
and if you have technical argument, I'd be happy to give in. :)

Thanks.

--
tejun


\
 
 \ /
  Last update: 2013-12-12 20:21    [W:0.026 / U:5.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site