Messages in this thread Patch in this message | | | From | Ramkumar Ramachandra <> | Date | Thu, 12 Dec 2013 13:04:04 +0530 | Subject | Re: [PATCH] perf list: fix --raw-dump |
| |
David Ahern wrote: > Why not make raw_dump a proper argument?
Sure, that'd work too. I was thinking of a minimal way to fix the problem myself.
> diff --git a/tools/perf/builtin-list.c b/tools/perf/builtin-list.c > index 011195e38f21..b553d0c4ca82 100644 > --- a/tools/perf/builtin-list.c > +++ b/tools/perf/builtin-list.c > @@ -36,6 +38,10 @@ int cmd_list(int argc, const char > print_events(NULL, false); > return 0; > } > + if (raw_dump) { > + print_events(NULL, true); > + return 0; > + }
This won't work because you've put it right below the `if (argc == 0)`, which executes print_events(). You could move it up and get it to work. From 7198a494cfef43395e8683ac3a0576277b8d1d80 Mon Sep 17 00:00:00 2001 From: David Ahern <dsahern@gmail.com> Date: Wed, 11 Dec 2013 14:00:20 -0700 Subject: [PATCH] perf list: Fix raw-dump arg
Ramkumar reported that perf list --raw-dump was broken by 44d742e. Fix by making raw-dump a proper argument.
Signed-off-by: David Ahern <dsahern@gmail.com> Cc: Ingo Molnar <mingo@kernel.org> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Ramkumar Ramachandra <artagnon@gmail.com> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com> --- tools/perf/builtin-list.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-list.c b/tools/perf/builtin-list.c index 011195e..2629c24 100644 --- a/tools/perf/builtin-list.c +++ b/tools/perf/builtin-list.c @@ -19,7 +19,9 @@ int cmd_list(int argc, const char **argv, const char *prefix __maybe_unused) { int i; + bool raw_dump = false; const struct option list_options[] = { + OPT_BOOLEAN(0, "raw-dump", &raw_dump, "raw dump for completion"), OPT_END() }; const char * const list_usage[] = { @@ -32,6 +34,10 @@ int cmd_list(int argc, const char **argv, const char *prefix __maybe_unused) setup_pager(); + if (raw_dump) { + print_events(NULL, true); + return 0; + } if (argc == 0) { print_events(NULL, false); return 0; @@ -53,8 +59,6 @@ int cmd_list(int argc, const char **argv, const char *prefix __maybe_unused) print_hwcache_events(NULL, false); else if (strcmp(argv[i], "pmu") == 0) print_pmu_events(NULL, false); - else if (strcmp(argv[i], "--raw-dump") == 0) - print_events(NULL, true); else { char *sep = strchr(argv[i], ':'), *s; int sep_idx; -- 1.8.5.1.113.g8cb5bef.dirty
| |