lkml.org 
[lkml]   [2013]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 09/14] efi: passing kexec necessary efi data via setup_data
> > > 
> > > +void __init parse_efi_setup(u64 phys_addr)
> > > +{
> > > + struct setup_data *sd;
> > > +
> > > + if (!efi_enabled(EFI_64BIT)) {
> > > + pr_warn("SETUP_EFI not supported on 32-bit\n");
> > > + return;
> > > + }
> >
> > Shouldn't this function be in two versions in efi_64.c and efi_32.c?
> > This way you don't need this check with cryptic printk message.
>
> Ok, will update.

Rethink about this issue, moving them to efi_$(BITS).c I need move the
efi_setup from a static variable to an extern, It looks not worth.

Thanks
Dave


\
 
 \ /
  Last update: 2013-12-12 08:41    [W:0.348 / U:0.824 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site