Messages in this thread |  | | Date | Thu, 12 Dec 2013 09:55:10 -0700 | From | David Ahern <> | Subject | Re: [PATCH] perf list: fix --raw-dump |
| |
On 12/12/13, 12:34 AM, Ramkumar Ramachandra wrote: > David Ahern wrote: >> Why not make raw_dump a proper argument? > > Sure, that'd work too. I was thinking of a minimal way to fix the > problem myself. > >> diff --git a/tools/perf/builtin-list.c b/tools/perf/builtin-list.c >> index 011195e38f21..b553d0c4ca82 100644 >> --- a/tools/perf/builtin-list.c >> +++ b/tools/perf/builtin-list.c >> @@ -36,6 +38,10 @@ int cmd_list(int argc, const char >> print_events(NULL, false); >> return 0; >> } >> + if (raw_dump) { >> + print_events(NULL, true); >> + return 0; >> + } > > This won't work because you've put it right below the `if (argc == > 0)`, which executes print_events(). You could move it up and get it to > work. >
your updated patch looks good to me.
David
|  |