Messages in this thread |  | | Date | Thu, 12 Dec 2013 09:53:07 -0700 | From | David Ahern <> | Subject | Re: [PATCH 1/2] perf completion: complete 'perf kvm' |
| |
On 12/12/13, 2:09 AM, Ramkumar Ramachandra wrote: > David Ahern wrote: >> I don't like the command list being embedded in the completion script. It >> will get outdated quickly. > > I could introduce a > > $ perf kvm --list-cmds > > but that would mean a > > printf("record report stat ..") > > in builtin-kvm.c, because the commands aren't in any sort of array. >
That would work -- perhaps a #define or string near
const char * const kvm_usage[] = { "perf kvm [<options>] {top|record|report|diff|buildid-list|stat}", NULL };
Building kvm_usage from the string would better - only 1 place listing the commands.
David
|  |