lkml.org 
[lkml]   [2013]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/38] perf tools: Use asprintf instead of malloc plus snprintf
Em Wed, Dec 11, 2013 at 02:16:50PM -0800, Andi Kleen escreveu:
> On Wed, Dec 04, 2013 at 05:06:25PM -0300, Arnaldo Carvalho de Melo wrote:
> > From: Adrian Hunter <adrian.hunter@intel.com>
> >
> > The asprintf library function is equivalent to malloc plus snprintf so
> > use it because it is simpler.
>
> I used to be very fond of asprintf too, but apparently there are some
> really ancient glibc versions that implement it incorrectly.
> I had to remove it from mcelog at some point because of that.
>
> No need to yank it out, but just to let you know.

Can you point me to some specific glibc version where this happens? So
that we can write a feature test and if this problem is detected, then
we can provide a simple malloc + snprintf alternative that works as
expected.

- Arnaldo


\
 
 \ /
  Last update: 2013-12-12 17:41    [W:0.146 / U:1.764 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site