Messages in this thread |  | | From | "Kirill A. Shutemov" <> | Subject | RE: [PATCH 2/2] mm: blk-mq: uses page->list incorrectly | Date | Thu, 12 Dec 2013 15:16:36 +0200 (EET) |
| |
Dave Hansen wrote: > > From: Dave Hansen <dave.hansen@linux.intel.com> > > 'struct page' has two list_head fields: 'lru' and 'list'. > Conveniently, they are unioned together. This means that code > can use them interchangably, which gets horribly confusing. > > The blk-mq made the logical decision to try to use page->list. > But, that field was actually introduced just for the slub code. > ->lru is the right field to use outside of slab/slub. > > Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Looks good to me.
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
for both.
-- Kirill A. Shutemov
|  |