[lkml]   [2013]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRE: [PATCH 2/2] mm: blk-mq: uses page->list incorrectly
Dave Hansen wrote:
> From: Dave Hansen <>
> 'struct page' has two list_head fields: 'lru' and 'list'.
> Conveniently, they are unioned together. This means that code
> can use them interchangably, which gets horribly confusing.
> The blk-mq made the logical decision to try to use page->list.
> But, that field was actually introduced just for the slub code.
> ->lru is the right field to use outside of slab/slub.
> Signed-off-by: Dave Hansen <>

Looks good to me.

Acked-by: Kirill A. Shutemov <>

for both.

Kirill A. Shutemov

 \ /
  Last update: 2013-12-12 14:41    [W:0.191 / U:1.680 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site