Messages in this thread | | | Date | Wed, 11 Dec 2013 09:45:52 +0200 | From | Ivajlo Dimitrov <> | Subject | Re: [PATCH] Staging: TIDSPBRIDGE: Use vm_iomap_memory for mmap-ing instead of remap_pfn_range |
| |
On 08.12.2013 01:49, Steven Luo wrote: > This patch causes problems with DSP codecs on OMAP3 devices running > Android -- specifically, when the decoder is cleaning up after itself, > munmap() of the mapped area fails, leading to a memory leak which > eventually crashes the system. > > As far as I can tell, the code with this patch applied reduces to > (ignoring checks and such) > > remap_pfn_range(vma, vma->vm_start, > (pdata->phys_mempool_base >> PAGE_SHIFT) + vma->vm_pgoff, > vma->vm_end - vma->vm_start, > vma->vm_page_prot); > > whereas the original was > >> - status = remap_pfn_range(vma, vma->vm_start, vma->vm_pgoff, >> - vma->vm_end - vma->vm_start, >> - vma->vm_page_prot); > We're subtracting (pdata->phys_mempool_base >> PAGE_SHIFT) from > vma->vm_pgoff before calling vm_iomap_memory() to address the issue -- > if that's satisfactory to everyone involved, I can submit the following > patch. > > Hi,
I can pick your changes and re-send the original patch with them incorporated if there are no objections. Are you fine with that?
Regards, Ivo
| |