Messages in this thread | | | Date | Wed, 11 Dec 2013 20:30:10 +0100 | Subject | Re: [RFC PATCH] drivers: char: Add a dynamic clock for the trace clock | From | Stephane Eranian <> |
| |
Sonny,
Your patch has a couple of problems for me: - requires CONFIG_TRACING
You should directly invoke getrawmonotonic() and inline the code from trace_clock_getres().
That's how I managed to compile your kernel module on my system.
On Mon, Dec 9, 2013 at 8:49 AM, Josh Triplett <josh@joshtriplett.org> wrote: > On Fri, Dec 06, 2013 at 04:34:11PM -0800, Sonny Rao wrote: >> Based on a suggestion from John Stultz. >> >> This adds a dynamic clock device which can be used with clock_gettime >> to sample the clock source used for time stamping trace events in the >> kernel. The only use for this clock source is to associate user space >> events with kernel events on a given kernel. It is explicitly not >> supposed to be used as a generic time source and won't necessarily be >> consistent between kernels. >> >> Signed-off-by: Sonny Rao <sonnyrao@chromium.org> > > Reviewed-by: Josh Triplett <josh@joshtriplett.org>
| |