Messages in this thread | | | Date | Wed, 11 Dec 2013 13:27:29 +0000 | From | Mark Brown <> | Subject | Re: [PATCH 3/8] regmap: Add support for using regmap over ssbi |
| |
On Tue, Dec 10, 2013 at 05:32:51PM -0800, Stephen Boyd wrote:
> Are you suggesting we implement the reg_read/reg_write as global helpers > that the config points to and then call regmap_init()? At a quick glance
Yes, assuming your bus really is limited in the way it seems from the code.
> it looks like we lose out on regmap_bulk_read() if we do that. There is > one driver that will use regmap_bulk_read(), but I suppose we can just
bulk_read() should decay to individual reads if there isn't a block operaton and it's not like the hardware actually supports bulk reads anyway.
> With use_single_rw I think it can be this.
> static int regmap_ssbi_read(void *context, > const void *reg, size_t reg_size, > void *val, size_t val_size) > { > BUG_ON(reg_size != 2); > return ssbi_read(context, *(u16 *)reg, val, 1); > }
Right, which is a lot simpler. Though I'm still not sure the ssbi_read() interface is the best. [unhandled content-type:application/pgp-signature] | |