Messages in this thread | | | Date | Wed, 11 Dec 2013 13:55:42 +0800 | From | Rui Xiang <> | Subject | Re: [PATCH RESEND 1/2] proc: change return values while get_proc_task err |
| |
On 2013/12/11 7:02, Andrew Morton wrote: > On Mon, 9 Dec 2013 20:11:54 +0800 Rui Xiang <rui.xiang@huawei.com> wrote: > >> While getting proc task error, it shoule return -ESRCH. >> >> ... >> >> --- a/fs/proc/base.c >> +++ b/fs/proc/base.c >> @@ -174,9 +174,10 @@ static int get_task_root(struct task_struct *task, struct path *root) >> static int proc_cwd_link(struct dentry *dentry, struct path *path) >> { >> struct task_struct *task = get_proc_task(dentry->d_inode); >> - int result = -ENOENT; >> + int result = -ESRCH; > > I suppose so. But there is risk here of breaking existing applications > and I don't think this problem is serious enough to justify that risk? > Got it. Thanks for your comment.
Thanks Rui
| |