Messages in this thread Patch in this message |  | | Date | Wed, 11 Dec 2013 03:03:40 -0800 | From | tip-bot for David Ahern <> | Subject | [tip:perf/core] perf trace: Fix summary percentage when processing files |
| |
Commit-ID: 3160565f0e005d2ec736ae25cf0a79988c0cbe71 Gitweb: http://git.kernel.org/tip/3160565f0e005d2ec736ae25cf0a79988c0cbe71 Author: David Ahern <dsahern@gmail.com> AuthorDate: Wed, 4 Dec 2013 19:41:41 -0700 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Thu, 5 Dec 2013 10:09:58 -0300
perf trace: Fix summary percentage when processing files
Getting a divide by 0 when events are processed from a file:
perf trace -i perf.data -s ... dnsmasq (1684), 10 events, inf%, 0.000 msec
The problem is that the event count is not incremented as events are processed. With this patch:
perf trace -i perf.data -s ... dnsmasq (1684), 10 events, 8.9%, 0.000 msec
Signed-off-by: David Ahern <dsahern@gmail.com> Link: http://lkml.kernel.org/r/1386211302-31303-4-git-send-email-dsahern@gmail.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/builtin-trace.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index a7aa771..56bbca5 100644 --- a/tools/perf/builtin-trace.c +++ b/tools/perf/builtin-trace.c @@ -1770,8 +1770,10 @@ static int trace__process_sample(struct perf_tool *tool, if (!trace->full_time && trace->base_time == 0) trace->base_time = sample->time; - if (handler) + if (handler) { + ++trace->nr_events; handler(trace, evsel, sample); + } return err; }
|  |