lkml.org 
[lkml]   [2013]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH V2 2/6] mm: compaction: encapsulate defer reset logic
    Date
    Currently there are several functions to manipulate the deferred compaction
    state variables. The remaining case where the variables are touched directly
    is when a successful allocation occurs in direct compaction, or is expected
    to be successful in the future by kswapd. Here, the lowest order that is
    expected to fail is updated, and in the case of successful allocation, the
    deferred status and counter is reset completely.

    Create a new function compaction_defer_reset() to encapsulate this
    functionality and make it easier to understand the code. No functional change.

    Acked-by: Mel Gorman <mgorman@suse.de>
    Reviewed-by: Rik van Riel <riel@redhat.com>
    Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
    ---
    include/linux/compaction.h | 16 ++++++++++++++++
    mm/compaction.c | 9 ++++-----
    mm/page_alloc.c | 5 +----
    3 files changed, 21 insertions(+), 9 deletions(-)

    diff --git a/include/linux/compaction.h b/include/linux/compaction.h
    index 091d72e..7e1c76e 100644
    --- a/include/linux/compaction.h
    +++ b/include/linux/compaction.h
    @@ -62,6 +62,22 @@ static inline bool compaction_deferred(struct zone *zone, int order)
    return zone->compact_considered < defer_limit;
    }

    +/*
    + * Update defer tracking counters after successful compaction of given order,
    + * which means an allocation either succeeded (alloc_success == true) or is
    + * expected to succeed.
    + */
    +static inline void compaction_defer_reset(struct zone *zone, int order,
    + bool alloc_success)
    +{
    + if (alloc_success) {
    + zone->compact_considered = 0;
    + zone->compact_defer_shift = 0;
    + }
    + if (order >= zone->compact_order_failed)
    + zone->compact_order_failed = order + 1;
    +}
    +
    /* Returns true if restarting compaction after many failures */
    static inline bool compaction_restarting(struct zone *zone, int order)
    {
    diff --git a/mm/compaction.c b/mm/compaction.c
    index bb50fd3..e431804 100644
    --- a/mm/compaction.c
    +++ b/mm/compaction.c
    @@ -1120,12 +1120,11 @@ static void __compact_pgdat(pg_data_t *pgdat, struct compact_control *cc)
    compact_zone(zone, cc);

    if (cc->order > 0) {
    - int ok = zone_watermark_ok(zone, cc->order,
    - low_wmark_pages(zone), 0, 0);
    - if (ok && cc->order >= zone->compact_order_failed)
    - zone->compact_order_failed = cc->order + 1;
    + if (zone_watermark_ok(zone, cc->order,
    + low_wmark_pages(zone), 0, 0))
    + compaction_defer_reset(zone, cc->order, false);
    /* Currently async compaction is never deferred. */
    - else if (!ok && cc->sync)
    + else if (cc->sync)
    defer_compaction(zone, cc->order);
    }

    diff --git a/mm/page_alloc.c b/mm/page_alloc.c
    index 580a5f0..50c7f67 100644
    --- a/mm/page_alloc.c
    +++ b/mm/page_alloc.c
    @@ -2243,10 +2243,7 @@ __alloc_pages_direct_compact(gfp_t gfp_mask, unsigned int order,
    preferred_zone, migratetype);
    if (page) {
    preferred_zone->compact_blockskip_flush = false;
    - preferred_zone->compact_considered = 0;
    - preferred_zone->compact_defer_shift = 0;
    - if (order >= preferred_zone->compact_order_failed)
    - preferred_zone->compact_order_failed = order + 1;
    + compaction_defer_reset(preferred_zone, order, true);
    count_vm_event(COMPACTSUCCESS);
    return page;
    }
    --
    1.8.4


    \
     
     \ /
      Last update: 2013-12-11 12:01    [W:2.814 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site