Messages in this thread | | | Date | Tue, 10 Dec 2013 14:00:36 -0500 (EST) | Subject | Re: [PATCH 2/2] tun: remove useless codes in tun_chr_aio_read() and tun_recvmsg() | From | David Miller <> |
| |
From: Vlad Yasevich <vyasevich@gmail.com> Date: Tue, 10 Dec 2013 12:18:09 -0500
> On 12/09/2013 08:36 PM, David Miller wrote: >> From: Zhi Yong Wu <zwu.kernel@gmail.com> >> Date: Sat, 7 Dec 2013 04:55:00 +0800 >> >>> From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com> >>> >>> By checking related codes, it is impossible that ret > len or total_len, >>> so we should remove some useless codes in both above functions. >>> >>> Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com> >> >> Applied. > > Wait a sec. We want to be able to return a value bigger then len > to trigger a MSG_TRUNC. Jason has patches for to fix this. If you > apply this, we'll have to re-introduce this code back in. > > Same goes for patch 1/2.
That's fine, right now the code makes no sense as the condition can never be triggered so there is no harm removing the illogical code meanwhile.
| |