Messages in this thread |  | | Date | Wed, 11 Dec 2013 10:26:30 +0900 | From | Masami Hiramatsu <> | Subject | Re: [PATCH 10/17] tracing/probes: Move 'symbol' fetch method to kprobes |
| |
(2013/12/11 10:05), Namhyung Kim wrote: > Hi Masami, > > On Tue, 10 Dec 2013 19:12:36 +0900, Masami Hiramatsu wrote: >> (2013/12/09 15:19), Namhyung Kim wrote: >> >>> diff --git a/kernel/trace/trace_probe.h b/kernel/trace/trace_probe.h >>> index 23b2d83ee5fb..d327a1c21f4b 100644 >>> --- a/kernel/trace/trace_probe.h >>> +++ b/kernel/trace/trace_probe.h >>> @@ -239,6 +239,30 @@ ASSIGN_FETCH_FUNC(bitfield, ftype), \ >>> extern __weak const struct fetch_type kprobes_fetch_type_table[]; >>> extern __weak const struct fetch_type uprobes_fetch_type_table[]; >>> >>> +#ifdef CONFIG_KPROBE_EVENT >>> +struct symbol_cache; >>> +unsigned long update_symbol_cache(struct symbol_cache *sc); >>> +void free_symbol_cache(struct symbol_cache *sc); >>> +struct symbol_cache *alloc_symbol_cache(const char *sym, long offset); >>> +#else >>> +struct symbol_cache { >>> +}; >>> +static unsigned long __used update_symbol_cache(struct symbol_cache *sc) >>> +{ >>> + return 0; >>> +} >>> + >>> +static void __used free_symbol_cache(struct symbol_cache *sc) >>> +{ >>> +} >>> + >>> +static struct symbol_cache * __used >>> +alloc_symbol_cache(const char *sym, long offset) >>> +{ >>> + return NULL; >>> +} >>> +#endif /* CONFIG_KPROBE_EVENT */ >> >> Hmm, defining non-inline function in the header looks odd. >> Maybe you'd better do this (or define __weak instances) >> in trace_probe.c. > > Or just make them static inline?
Exactly, yes. ;)
Thank you,
-- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com
|  |