[lkml]   [2013]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] [RFC] mm: slab: separate slab_page from 'struct page'
On 12/10/2013 01:07 PM, Christoph Lameter wrote:
> On Tue, 10 Dec 2013, Dave Hansen wrote:
>> At least for slab, this doesn't turn out to be too big of a deal:
>> it's only 8 casts. slub looks like it'll be a bit more work, but
>> still manageable.
> The single page struct definitions makes it easy to see how a certain
> field is being used in various subsystems. If you add a field then you
> can see other use cases in other subsystems. If you happen to call
> them then you know that there is trouble afoot.

First of all, I'd really argue with the assertion that the way it is now
make it easy to figure anything out. Maybe we can take a vote. :)

We _need_ to share fields when the structure is handed between different
subsystems and it needs to be consistent in both places. For slab page
at least, the only data that actually gets used consistently is
page->flags. It seems silly to bend over backwards just to share a
single bitfield.

> How do you ensure that the sizes and the locations of the fields in
> multiple page structs stay consistent?

Check out the BUILD_BUG_ON(). That shows one example of how we do it
for a field location. We could do the same for sizeof() the two.

> As far as I can tell we are trying to put everything into one page struct
> to keep track of the uses of various fields and to allow a reference for
> newcomes to the kernel.

If the goal is to make a structure which is approachable to newcomers to
the kernel, then I think we've utterly failed.

 \ /
  Last update: 2013-12-10 23:01    [W:0.051 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site