Messages in this thread | | | Date | Tue, 10 Dec 2013 12:08:20 -0800 | Subject | Re: [PATCH 2/2] word-at-a-time: provide generic big-endian zero_bytemask implementation | From | Linus Torvalds <> |
| |
Hmm. Did you try to time this?
Also, I really have #ifdef's in code, and I think we'd be better off just exposing a function that does this
+#ifdef __BIG_ENDIAN + mask = ~(~0ul >> tcount*8); +#else mask = ~(~0ul << tcount*8); +#endif
thing. I think it would logically go together with zero_bytemask(), call it something like "bytemask_from_count()" or something. Hmm? It's basically just the reverse of "count_masked_bytes()", which we also have an abstraction for.
So the #ifdef really looks out of place for me. We've generated all these nice abstractions for all the other mask handling, and then you add that ugly ifdef for this case.
Linus
| |