Messages in this thread | | | Date | Tue, 10 Dec 2013 02:11:24 -0500 | From | Naoya Horiguchi <> | Subject | Re: [PATCH v3 11/12] sched/numa: drop unnecessary variable in task_weight |
| |
On Sun, Dec 08, 2013 at 02:14:52PM +0800, Wanpeng Li wrote: > Drop unnecessary total_faults variable in function task_weight to unify > task_weight and group_weight. > > Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> --- > kernel/sched/fair.c | 11 ++--------- > 1 files changed, 2 insertions(+), 9 deletions(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 942e67b..df8b677 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -947,17 +947,10 @@ static inline unsigned long group_faults(struct task_struct *p, int nid) > */ > static inline unsigned long task_weight(struct task_struct *p, int nid) > { > - unsigned long total_faults; > - > - if (!p->numa_faults) > - return 0; > - > - total_faults = p->total_numa_faults; > - > - if (!total_faults) > + if (!p->numa_faults || !p->total_numa_faults) > return 0; > > - return 1000 * task_faults(p, nid) / total_faults; > + return 1000 * task_faults(p, nid) / p->total_numa_faults; > } > > static inline unsigned long group_weight(struct task_struct *p, int nid) > -- > 1.7.5.4 >
| |