lkml.org 
[lkml]   [2013]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 03/15] mfd: menelaus: Convert to threaded irq
Hi,

On Tue, Dec 10, 2013 at 09:32:13AM +0000, Lee Jones wrote:
> On Mon, 09 Dec 2013, Felipe Balbi wrote:
>
> > We don't need that extra workqueue when we have generic threaded irq
> > handlers support. This patch just moves over to threaded irqs and
> > deletes the unnecessary workqueue.
> >
> > Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > ---
> > drivers/mfd/menelaus.c | 29 ++++-------------------------
> > 1 file changed, 4 insertions(+), 25 deletions(-)
>
> <snip>
>
> > - err = request_irq(client->irq, menelaus_irq, 0,
> > - DRIVER_NAME, menelaus);
> > + err = request_threaded_irq(client->irq, NULL, menelaus_irq,
> > + IRQF_ONESHOT, DRIVER_NAME, menelaus);
>
> devm_* managed resources please.

that would be subject to another patch. One that converts to devm_* on
the entire driver.

--
balbi
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2013-12-10 18:01    [W:1.084 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site