lkml.org 
[lkml]   [2013]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] net-tg3: Initialize REG_BASE_ADDR at PCI config offset 120 to 0
From
Michael,
The only time I see crashes is after the tg3 driver has been
loaded into the system. I our use case we are poking around
/sys/devices/pcixxxx/......../config.
I guess you will incorporate the original patch into the driver
and we can abandon this patch.

Regards
Nat


On Mon, Dec 9, 2013 at 10:58 PM, Michael Chan <mchan@broadcom.com> wrote:
> On Mon, 2013-12-09 at 13:07 -0800, Michael Chan wrote:
>> On Tue, 2013-12-10 at 00:18 +0300, Sergei Shtylyov wrote:
>> > > We had crashes when the PCI config space got scanned via
>> > > /sys/devices/pcixxxx/....../config.
>> >
>> > > I agree that this fix will not help if the scan happens before the tg3
>> > > driver gets loaded.
>> >
>> > Then perhaps a better place for such fixup would be a PCI quirk?
>> >
>> Yes, I agree. Thanks.
>>
>
> On second thought, I think your original patch should be sufficient and
> we don't need to add the PCI quirk to cover so many devices. The reason
> is that indirect access needs to be explicitly enabled in the
> MISC_HOST_CTRL (0x68) register. The default value for register 0x68
> should have indirect access disabled.
>
> Nat, does this match what you're seeing? Did you ever see any system
> crash before tg3 loads?
>



--
Regards
Nat Gurumoorthy AB6SJ


\
 
 \ /
  Last update: 2013-12-10 16:41    [W:0.073 / U:2.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site