lkml.org 
[lkml]   [2013]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 3.12 46/62] irq: Enable all irqs unconditionally in irq_resume
Date
Am Dienstag, 10. Dezember 2013, 10:08:47 schrieb Greg Kroah-Hartman:
> On Tue, Dec 10, 2013 at 10:01:13AM +0100, Pavel Machek wrote:
> > Hi!
> >
> > > 3.12-stable review patch. If anyone has any objections, please let
> > >
> > > me know.
> >
> > Objections... well... I'm not sure if it meets stable criteria. In
> > particular, I don't think it was ever demonstrated as having bad
> > effect on the users.
>
> Well, I'm guessing someone on the cc: here wanted it in stable@, so I'll
> let them speak up as to why...

As for bad effects on users ... any suspend_noirq callback returning an error
and thus aborting the suspend will cause the error fixed by this, as the
early-irqs won't get reenabled in the suspend-rollback [due to the syscore_ops
doing their resume never being run].

You could for example lose keys connected thru the gpio-keys driver until the
next reboot.

And it seems at least Laxman and myself were affected by it.


Heiko


\
 
 \ /
  Last update: 2013-12-10 14:01    [W:0.088 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site