lkml.org 
[lkml]   [2013]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 02/11] arm: pxa27x: support ICP DAS LP-8x4x
    From
    On Fri, Dec 6, 2013 at 6:14 PM, Arnd Bergmann <arnd@arndb.de> wrote:
    > On Friday 06 December 2013, Sergei Ianovich wrote:
    >> On Fri, 2013-12-06 at 01:40 +0100, Arnd Bergmann wrote:
    >>
    >> > > +
    >> > > +static struct irq_chip lp8x4x_irq_chip = {
    >> > > + .name = "FPGA",
    >> > > + .irq_ack = lp8x4x_ack_irq,
    >> > > + .irq_mask = lp8x4x_mask_irq,
    >> > > + .irq_unmask = lp8x4x_unmask_irq,
    >> > > +};
    >> >
    >> > Please try to move the irqchip code to drivers/irqchip/.
    >>
    >> CONFIG_IRQCHIP depends on CONFIG_OF_IRQ which in turn depends on Open
    >> Firmware.
    >
    > Hmm, I wonder if we should try to change Kconfig then. Let's leave it
    > alone for now, maybe Linus Walleij has some comments since he has
    > been looking into moving drivers out in the past.

    I don't get this, if the subarch has deps in place for IRQCHIP and
    OF_IRQ just move the implementation to drivers/irqchip/foo.c
    edit drivers/irqchip/Makefile to compile the file for ARCH_FOO.
    What would the problem be? It's not like having the irqchip in the
    object is optional...

    I would prefer if you augment the code to use
    IRQCHIP_DECLARE() so you can get rid of all the criss-cross
    calls, but this init contains a comment saying that GPIO
    has to be up before you initialize the irq_chip, can you please
    explain why it's like that?

    Another way is to create a separate Kconfig entry for it in
    drivers/irqchip/Kconfig if you want the set-up to be more
    distributed, but that is usually just done when the irqchip is
    used on more than one platform.

    Yours,
    Linus Walleij


    \
     
     \ /
      Last update: 2013-12-10 14:01    [W:4.159 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site