lkml.org 
[lkml]   [2013]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:perf/core] tools lib traceevent: Use static functions in jbd2 plugin
    Commit-ID:  f04015ecb5eb0bf25260de585f0c5f60e84f073a
    Gitweb: http://git.kernel.org/tip/f04015ecb5eb0bf25260de585f0c5f60e84f073a
    Author: Jiri Olsa <jolsa@redhat.com>
    AuthorDate: Tue, 3 Dec 2013 14:09:37 +0100
    Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
    CommitDate: Wed, 4 Dec 2013 15:36:24 -0300

    tools lib traceevent: Use static functions in jbd2 plugin

    There's no need for following functions to be global:

    process_jbd2_dev_to_name
    process_jiffies_to_msecs

    Make them static.

    Signed-off-by: Jiri Olsa <jolsa@redhat.com>
    Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Steven Rostedt <rostedt@goodmis.org>
    Link: http://lkml.kernel.org/r/1386076182-14484-24-git-send-email-jolsa@redhat.com
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/lib/traceevent/plugin_jbd2.c | 10 ++++++----
    1 file changed, 6 insertions(+), 4 deletions(-)

    diff --git a/tools/lib/traceevent/plugin_jbd2.c b/tools/lib/traceevent/plugin_jbd2.c
    index 5d85de7..2f93f81 100644
    --- a/tools/lib/traceevent/plugin_jbd2.c
    +++ b/tools/lib/traceevent/plugin_jbd2.c
    @@ -29,8 +29,9 @@
    #define MAJOR(dev) ((unsigned int) ((dev) >> MINORBITS))
    #define MINOR(dev) ((unsigned int) ((dev) & MINORMASK))

    -unsigned long long process_jbd2_dev_to_name(struct trace_seq *s,
    - unsigned long long *args)
    +static unsigned long long
    +process_jbd2_dev_to_name(struct trace_seq *s,
    + unsigned long long *args)
    {
    unsigned int dev = args[0];

    @@ -38,8 +39,9 @@ unsigned long long process_jbd2_dev_to_name(struct trace_seq *s,
    return 0;
    }

    -unsigned long long process_jiffies_to_msecs(struct trace_seq *s,
    - unsigned long long *args)
    +static unsigned long long
    +process_jiffies_to_msecs(struct trace_seq *s,
    + unsigned long long *args)
    {
    unsigned long long jiffies = args[0];


    \
     
     \ /
      Last update: 2013-12-10 13:21    [W:4.107 / U:0.284 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site