Messages in this thread | | | Date | Tue, 10 Dec 2013 15:08:51 +0530 | Subject | Re: [TRIVIAL PATCH 1/2] regulator: s5m8767: Define symbol for buck control mask | From | Sachin Kamat <> |
| |
On 10 December 2013 15:00, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote: > On Tue, 2013-12-10 at 14:48 +0530, Sachin Kamat wrote: >> Hi Krzysztof, >> >> On 10 December 2013 14:39, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote: >> >> > static int s5m8767_reg_disable(struct regulator_dev *rdev) >> > { >> > struct s5m8767_info *s5m8767 = rdev_get_drvdata(rdev); >> > int ret, reg; >> > - int mask = 0xc0, enable_ctrl; >> > + int mask = S5M8767_ENCTRL_MASK, enable_ctrl; >> >> Couldn't we get rid of this mask variable here too? >> >> Otherwise the patch looks good to me. > > Not in this patch because it leads to warning: > > drivers/regulator/s5m8767.c: In function ‘s5m8767_reg_disable’: > drivers/regulator/s5m8767.c:259:2: warning: large integer implicitly truncated to unsigned type [-Woverflow] > drivers/regulator/s5m8767.c:253:6: warning: unused variable ‘mask’ [-Wunused-variable]
I see.
> > I plan to remove the sec_reg_*() helpers because they are confusing > and error-prone (mixing u8 and unsigned int). After using standard regmap > API this "mask" variable could be removed.
Sounds good.
For the subject patch, Reviewed-by: Sachin Kamat <sachin.kamat@linaro.org>
-- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |