Messages in this thread | | | Date | Tue, 10 Dec 2013 08:13:08 +0000 | From | "Jan Beulich" <> | Subject | Re: [Xen-devel] [RFC][PATCH 3/3] timekeeping: Fix potential lost pv notification of time change |
| |
>>> On 10.12.13 at 06:09, John Stultz <john.stultz@linaro.org> wrote: > static cycle_t logarithmic_accumulation(struct timekeeper *tk, cycle_t offset, > - u32 shift) > + u32 shift, int *action)
With plain int used here, ...
> @@ -1369,7 +1369,7 @@ static void update_wall_time(void) > struct timekeeper *tk = &shadow_timekeeper; > cycle_t offset; > int shift = 0, maxshift; > - unsigned int action; > + unsigned int action = 0;
... and unsigned int used here, ...
> @@ -1404,7 +1404,7 @@ static void update_wall_time(void) > maxshift = (64 - (ilog2(ntp_tick_length())+1)) - 1; > shift = min(shift, maxshift); > while (offset >= tk->cycle_interval) { > - offset = logarithmic_accumulation(tk, offset, shift); > + offset = logarithmic_accumulation(tk, offset, shift, &action);
... does this compile without warning for you?
Jan
| |