| Date | Tue, 10 Dec 2013 12:43:45 -0800 | Subject | Re: process 'stuck' at exit. | From | Linus Torvalds <> |
| |
On Tue, Dec 10, 2013 at 12:33 PM, Thomas Gleixner <tglx@linutronix.de> wrote: > > The -EAGAIN is when the user value changed, simplified:
No it's not.
Thomas, stop this crap already. Look at the f*cking code carefully instead of just dismissing cases.
The worrisome EAGAIN case is
futex_requeue futex_proxy_trylock_atomic futex_lock_pi_atomic lookup_pi_state: ret = (p->flags & PF_EXITPIDONE) ? -ESRCH : -EAGAIN;
and now futex_requeue() will do "goto repeat" for that EAGAIN case.
So, Christ, Thomas, you have now *twice* dismissed a real concern with totally bogus "that can never happen" by explaining some totally unrelated *simple* case rather than the much more complex case.
So please. Really. Truly look at the code and thing about it, or shut the f*ck up. No more of this shit where you glance at the code, find some simple case, and say "that can't happen", and dismiss the bug-report.
So far Dave's bug-reports have generally pretty much universally shown real bugs. Being dismissive about it is not helpful, quite the reverse.
Maybe the loop I'm pointing at cannot happen, but *your* explanation for why it couldn't happen was pure and utter garbage, and was clearly because you hadn't even bothered to look at all the cases.
Linus
|