Messages in this thread | | | Date | Tue, 10 Dec 2013 15:37:27 -0500 | From | Naoya Horiguchi <> | Subject | Re: [PATCH v4 09/12] sched/numa: fix period_slot recalculation |
| |
On Tue, Dec 10, 2013 at 05:19:32PM +0800, Wanpeng Li wrote: > Changelog: > v3 -> v4: > * remove period_slot recalculation > > The original code is as intended and was meant to scale the difference > between the NUMA_PERIOD_THRESHOLD and local/remote ratio when adjusting > the scan period. The period_slot recalculation can be dropped. > > Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Thanks, Naoya
> --- > kernel/sched/fair.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 7073c76..90b9b88 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -1356,7 +1356,6 @@ static void update_task_scan_period(struct task_struct *p, > * scanning faster if shared accesses dominate as it may > * simply bounce migrations uselessly > */ > - period_slot = DIV_ROUND_UP(diff, NUMA_PERIOD_SLOTS); > ratio = DIV_ROUND_UP(private * NUMA_PERIOD_SLOTS, (private + shared)); > diff = (diff * ratio) / NUMA_PERIOD_SLOTS; > } > -- > 1.7.7.6 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> >
| |