Messages in this thread | | | Date | Tue, 10 Dec 2013 20:38:54 -0700 | From | David Ahern <> | Subject | Re: [PATCH V3] perf tools: Change the default filenames for perf kvm diff to perf.data.xxx and perf.data.xxx.old |
| |
On 12/11/13, 9:30 AM, Dongsheng Yang wrote: > @@ -1001,8 +1002,28 @@ static int data_init(int argc, const char **argv) > use_default = false; > } > } else if (perf_guest) { > - defaults[0] = "perf.data.host"; > - defaults[1] = "perf.data.guest"; > + char *file_name; > + int len, ret; > + > + file_name = (char *)get_filename_for_perf_kvm(); > + if (!file_name) { > + pr_err("Failed to allocate memory for filename\n"); > + return -ENOMEM; > + } > +
The need for a typecast should tell you something is wrong. Why is get_filename_for_perf_kvm returning a const char * when it is allocated memory?
David
| |