Messages in this thread |  | | Date | Tue, 10 Dec 2013 21:56:54 -0500 (EST) | Subject | Re: [PATCH v1 1/6] net: mv643xx_eth: properly start/stop phy device | From | David Miller <> |
| |
From: David Miller <davem@davemloft.net> Date: Tue, 10 Dec 2013 21:52:53 -0500 (EST)
> > This series looks good, applied to net-next, thanks.
Actually, I had to revert.
You cannot use late_initcall_sync() from code that is potentially built modular, this caused my build to fail at the mdio_bus code.
drivers/net/phy/mdio_bus.c:344:1: warning: data definition has no type or storage class [enabled by default] drivers/net/phy/mdio_bus.c:344:1: error: type defaults to ‘int’ in declaration of ‘late_initcall_sync’ [-Werror=implicit-int] drivers/net/phy/mdio_bus.c:344:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/net/phy/mdio_bus.c:339:12: warning: ‘mdio_bus_class_suspend_unused’ defined but not used [-Wunused-function]
|  |