Messages in this thread |  | | Date | Sun, 1 Dec 2013 13:21:29 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCHv3 01/29] perf tools: Remove stackprotector feature check |
| |
* Jiri Olsa <jolsa@redhat.com> wrote:
> On Fri, Nov 29, 2013 at 03:34:39PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Thu, Nov 28, 2013 at 12:33:00PM +0100, Jiri Olsa escreveu: > > > We use -fstack-protector-all option to enable stack protecting > > > for all available functions. There's no reason for enabling > > > -Wstack-protector to get warning for unprotected functions. > > > > > > Removing stackprotector feature check which was used to > > > enable the -Wstack-protector option. > > > > Doesn't applies to my perf/core branch. > > yep, that's that libunwind stuff messing up ;-) > > attaching v3, I could resend whole rebased patchset if > needed.. I also updated my perf/core_plugins branch > > thanks, > jirka > > > --- > We use -fstack-protector-all option to enable stack protecting > for all available functions. There's no reason for enabling > -Wstack-protector to get warning for unprotected functions. > > Removing stackprotector feature check which was used to > enable the -Wstack-protector option. > > Signed-off-by: Jiri Olsa <jolsa@redhat.com> > Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com> > Cc: Frederic Weisbecker <fweisbec@gmail.com> > Cc: Ingo Molnar <mingo@elte.hu> > Cc: Namhyung Kim <namhyung@kernel.org> > Cc: Paul Mackerras <paulus@samba.org> > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> > Cc: Arnaldo Carvalho de Melo <acme@redhat.com> > Cc: Steven Rostedt <rostedt@goodmis.org> > Cc: David Ahern <dsahern@gmail.com> > --- > tools/perf/config/Makefile | 5 ----- > tools/perf/config/feature-checks/Makefile | 6 +----- > tools/perf/config/feature-checks/test-stackprotector.c | 6 ------ > 3 files changed, 1 insertion(+), 16 deletions(-) > delete mode 100644 tools/perf/config/feature-checks/test-stackprotector.c
Acked-by: Ingo Molnar <mingo@kernel.org>
This should also speed up the feature tests by about 10-20 msecs in the test-all case.
Thanks,
Ingo
|  |