lkml.org 
[lkml]   [2013]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.11 61/94] xtensa: dont use alternate signal stack on threads
    Date
    3.11-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Baruch Siach <baruch@tkos.co.il>

    commit cba9a90053e3b7973eff4f1946f33032e98eeed5 upstream.

    According to create_thread(3): "The new thread does not inherit the creating
    thread's alternate signal stack". Since commit f9a3879a (Fix sigaltstack
    corruption among cloned threads), current->sas_ss_size is set to 0 for cloned
    processes sharing VM with their parent. Don't use the (nonexistent) alternate
    signal stack in this case. This has been broken since commit 29c4dfd9 ([XTENSA]
    Remove non-rt signal handling).

    Fixes the SA_ONSTACK part of the nptl/tst-cancel20 test from uClibc.

    Signed-off-by: Baruch Siach <baruch@tkos.co.il>
    Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
    Signed-off-by: Chris Zankel <chris@zankel.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/xtensa/kernel/signal.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/arch/xtensa/kernel/signal.c
    +++ b/arch/xtensa/kernel/signal.c
    @@ -341,7 +341,7 @@ static int setup_frame(int sig, struct k

    sp = regs->areg[1];

    - if ((ka->sa.sa_flags & SA_ONSTACK) != 0 && ! on_sig_stack(sp)) {
    + if ((ka->sa.sa_flags & SA_ONSTACK) != 0 && sas_ss_flags(sp) == 0) {
    sp = current->sas_ss_sp + current->sas_ss_size;
    }




    \
     
     \ /
      Last update: 2013-11-09 08:41    [W:4.058 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site