lkml.org 
[lkml]   [2013]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.11 66/94] aacraid: missing capable() check in compat ioctl
    Date
    3.11-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit f856567b930dfcdbc3323261bf77240ccdde01f5 upstream.

    In commit d496f94d22d1 ('[SCSI] aacraid: fix security weakness') we
    added a check on CAP_SYS_RAWIO to the ioctl. The compat ioctls need the
    check as well.

    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/scsi/aacraid/linit.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/scsi/aacraid/linit.c
    +++ b/drivers/scsi/aacraid/linit.c
    @@ -771,6 +771,8 @@ static long aac_compat_do_ioctl(struct a
    static int aac_compat_ioctl(struct scsi_device *sdev, int cmd, void __user *arg)
    {
    struct aac_dev *dev = (struct aac_dev *)sdev->host->hostdata;
    + if (!capable(CAP_SYS_RAWIO))
    + return -EPERM;
    return aac_compat_do_ioctl(dev, cmd, (unsigned long)arg);
    }




    \
     
     \ /
      Last update: 2013-11-09 08:41    [W:5.336 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site