Messages in this thread Patch in this message | | | Date | Sat, 9 Nov 2013 15:16:26 +0000 | From | Mark Brown <> | Subject | Re: [PATCH] regmap: Fix compile warning with value uninitialized |
| |
On Sat, Nov 09, 2013 at 09:49:11AM +0000, Caizhiyong wrote:
> @@ -2170,7 +2170,8 @@ int regmap_register_patch(struct regmap *map, const struct reg_default *regs, > int num_regs) > { > struct reg_default *p; > - int i, ret; > + int i; > + int ret = 0; > bool bypass;
This sort of fix isn't ideal, it just silences the warning but if the compiler has spotted a genuine oversight in the function it won't address it. It's better to include some analysis of why this is a good fix. [unhandled content-type:application/pgp-signature] | |