Messages in this thread | | | From | "Dixit, Ashutosh" <> | Subject | RE: [PATCH] misc: mic: dead code removal and minor cleanup | Date | Sat, 9 Nov 2013 05:06:57 +0000 |
| |
> -----Original Message----- > From: Michael Opdenacker [mailto:michael.opdenacker@free-electrons.com] > Sent: Friday, November 08, 2013 8:14 PM > Subject: [PATCH] misc: mic: dead code removal and minor cleanup > > This removes the below test in drivers/misc/mic/card/mic_virtio.c: > > if (!retry) { > ... > } > > This is dead code because the "retry" variable was set to 100 > earlier in the same function. > > This also removes dev_dbg statements to print the value of this variable. > That's not interesting to print the value of a variable which value is > always the same.
Hi Michael,
Thanks for your mail. However, the dead code has resulted from another bug in the code, we should be decrementing retry instead of i. The same bug occurs in several other places in the code too.
So I would say don't apply this patch. We are planning a series of patches to fix other issues in the code when the 3.13 merge window closes and will include this fix too and include you in "Reported-by".
Thanks, Ashutosh
| |