lkml.org 
[lkml]   [2013]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 45/74] Staging: sb105x: info leak in mp_get_count()
    Date
    3.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit a8b33654b1e3b0c74d4a1fed041c9aae50b3c427 upstream.

    The icount.reserved[] array isn't initialized so it leaks stack
    information to userspace.

    Reported-by: Nico Golde <nico@ngolde.de>
    Reported-by: Fabian Yamaguchi <fabs@goesec.de>
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/staging/sb105x/sb_pci_mp.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/staging/sb105x/sb_pci_mp.c
    +++ b/drivers/staging/sb105x/sb_pci_mp.c
    @@ -1063,7 +1063,7 @@ static int mp_wait_modem_status(struct s

    static int mp_get_count(struct sb_uart_state *state, struct serial_icounter_struct *icnt)
    {
    - struct serial_icounter_struct icount;
    + struct serial_icounter_struct icount = {};
    struct sb_uart_icount cnow;
    struct sb_uart_port *port = state->port;




    \
     
     \ /
      Last update: 2013-11-09 10:21    [W:4.034 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site