Messages in this thread | | | Date | Fri, 08 Nov 2013 09:57:57 +0200 | From | Adrian Hunter <> | Subject | Re: [PATCH V3 06/11] perf record: Add an option to force per-cpu mmaps |
| |
On 05/11/13 19:31, Arnaldo Carvalho de Melo wrote: > PeterZ, > > Can I have your Acked-by for this one? I guess now the goal is > achieved, no?
Ping
> > - Arnaldo > > Em Tue, Nov 05, 2013 at 11:25:45AM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Tue, Nov 05, 2013 at 02:30:24PM +0100, Jiri Olsa escreveu: >>> On Tue, Nov 05, 2013 at 03:09:30PM +0200, Adrian Hunter wrote: >>>>> right, I haven't considered the hundreds CPU machine.. I just >>>>> saw that it disables inherited events in my test ;-) maybe we >>>>> could mentioned that somewhere, because it's not clear >>>> How about this: >>>> >>>> From: Adrian Hunter <adrian.hunter@intel.com> >>>> >>>> By default, when tasks are specified (i.e. -p, -t >>>> or -u options) per-thread mmaps are created. Add >>>> an option to override that and force per-cpu mmaps. >>>> >>>> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> >>> seems ok, thanks >> Much better, but may I ask that the explanation in the man pages be >> present in the changeset commit as well? So that by just looking at 'git >> log' we can more readily get the whole picture, i.e. scalability versus >> wanting to have inherit. >> >> - Arnaldo >> >>> Acked-by: Jiri Olsa <jolsa@redhat.com> >>> >>> jirka >
| |