Messages in this thread | | | Date | Thu, 7 Nov 2013 09:06:14 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 0/4] perf record: Cleanups and mmap-based output |
| |
* David Ahern <dsahern@gmail.com> wrote:
> I know Jiri is working on cleanups of the output file, but had this > sitting around for a couple of weeks now. Might as well push it out > for the next baseline. The cleanups of perf-record can be taken > independently. > > Ingo: I took a look at leveraging the copy_user_nocache and was not able > to get it to work. I won't have time to come back to it for a while. > Given that the mmap output already improves perf-trace a lot I would > like to get the option into 3.13 and come back to the optimization > later.
That's OK - your feature is already a big step forward!
1-3 look good to me and 4/4 needs some minor cleanups (see my review mail).
Thanks,
Ingo
| |