lkml.org 
[lkml]   [2013]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.8 67/91] clk: fixup argument order when setting VCO parameters
    Date
    3.8.13.13 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jonathan Austin <jonathan.austin@arm.com>

    commit 2f9f64bc5aa31836810cd25301aa4772ad73ebab upstream.

    The order of arguments in the call to vco_set() for the ICST clocks appears to
    have been switched in error, which results in the VCO not being initialised
    correctly. This in turn stops the integrated LCD on things like Integrator/CP
    from working correctly.

    This patch fixes the order and restores the expected functionality.

    Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Jonathan Austin <jonathan.austin@arm.com>
    Signed-off-by: Mike Turquette <mturquette@linaro.org>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    drivers/clk/versatile/clk-icst.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/clk/versatile/clk-icst.c b/drivers/clk/versatile/clk-icst.c
    index 67ccf4a..f5e4c21 100644
    --- a/drivers/clk/versatile/clk-icst.c
    +++ b/drivers/clk/versatile/clk-icst.c
    @@ -107,7 +107,7 @@ static int icst_set_rate(struct clk_hw *hw, unsigned long rate,

    vco = icst_hz_to_vco(icst->params, rate);
    icst->rate = icst_hz(icst->params, vco);
    - vco_set(icst->vcoreg, icst->lockreg, vco);
    + vco_set(icst->lockreg, icst->vcoreg, vco);
    return 0;
    }

    --
    1.8.1.2


    \
     
     \ /
      Last update: 2013-11-08 04:01    [W:3.777 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site